DB: playlists: make that 'insert' never raises

src/invidious/database/playlists.cr

@@ -94,18 +94,14 @@ module Invidious::Database::Playlists
   #  Salect
   # -------------------
 
-  def select(*, id : String, raise_on_fail : Bool = false) : InvidiousPlaylist?
+  def select(*, id : String) : InvidiousPlaylist?
     request = <<-SQL
       SELECT * FROM playlists
       WHERE id = $1
     SQL
 
-    if raise_on_fail
-      return PG_DB.query_one(request, id, as: InvidiousPlaylist)
-    else
     return PG_DB.query_one?(request, id, as: InvidiousPlaylist)
   end
-  end
 
   def select_all(*, author : String) : Array(InvidiousPlaylist)
     request = <<-SQL

src/invidious/routes/playlists.cr

@@ -151,14 +151,10 @@ module Invidious::Routes::Playlists
     page = env.params.query["page"]?.try &.to_i?
     page ||= 1
 
-    begin
+    playlist = Invidious::Database::Playlists.select(id: plid)
-      playlist = Invidious::Database::Playlists.select(id: plid, raise_on_fail: true)
     if !playlist || playlist.author != user.email
       return env.redirect referer
     end
-    rescue ex
-      return env.redirect referer
-    end
 
     begin
       videos = get_playlist_videos(playlist, offset: (page - 1) * 100, locale: locale)
@@ -235,14 +231,10 @@ module Invidious::Routes::Playlists
     page = env.params.query["page"]?.try &.to_i?
     page ||= 1
 
-    begin
+    playlist = Invidious::Database::Playlists.select(id: plid)
-      playlist = Invidious::Database::Playlists.select(id: plid, raise_on_fail: true)
     if !playlist || playlist.author != user.email
       return env.redirect referer
     end
-    rescue ex
-      return env.redirect referer
-    end
 
     query = env.params.query["q"]?
     if query