eca8d2e7d7
Apply suggestions from code review
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
cb0f7bf6b0
Change <input value="..."> encoding to HTML.escape
3 years ago
1ec15dc073
Propagate related videos changes to API function
3 years ago
f124e8cf93
Fix parsing of related videos
3 years ago
9621175dc9
extractors: Add helper for short view count text
3 years ago
e6ddd6d6c1
make HelperExtractors non-private
3 years ago
d7ebd763f5
video parsing: add secondary_results root element
3 years ago
99091e919c
video parsing: raise if major root element is missing
3 years ago
6ddbccbc95
Add new exception for parsing issues
3 years ago
4e44a91d08
Add support for clips
3 years ago
fc5f84a0cd
Merge pull request #2827 from SamantazFox/more-code-cleanup
...
More code cleanup
3 years ago
d546f1870e
Merge pull request #2845 from SamantazFox/more-db-improvements
...
More db improvements
3 years ago
f5cb7ba96c
Merge pull request #2833 from matthewmcgarvey/get-channel-cleanup
...
Channel helpers cleanup
3 years ago
519c227c4f
Use short syntax for 'File.open' block
3 years ago
6f4665588f
search.cr: use do/end rather than inline {} block
3 years ago
eba311baa9
Merge pull request #2397 from syeopite/dep-manager-for-videojs-stuff
...
Add dependency manager script for videojs stuff
3 years ago
e92b3779ad
Add back in refreshing of channels every 2 days
3 years ago
a82d21ff78
Cleanup channel helpers code
3 years ago
63e1165936
videos.cr: use '.dig?()' where possible
3 years ago
84cc732281
search functions: Don't return result count
...
This is useless, as the items count can be directly acessed
using the '.size' method, so use that instead when needed.
3 years ago
971b6ec96f
Fix 'Lint/UselessAssign' warnings reported by ameba
3 years ago
46f7ca9ffa
Remove useless intermediary variable in youtube_api.cr
...
This fixes an ameba warning
3 years ago
dee20f92a7
Avoid infinite loop in ChannelVideo's to_xml/to_json methods
3 years ago
12b818a83c
Fix more 'Lint/ShadowingOuterLocalVar' warnings reported by ameba
3 years ago
1c91110464
Fix some 'Lint/ShadowingOuterLocalVar' warnings reported by ameba
3 years ago
4cd7a3e83f
Remove useless 'locale = env.get...' from many routes
3 years ago
fa99c9aa85
Use '.dig?()' in playlist parsing
3 years ago
2d949834e9
Make 'additional_fields' optional in JSON error template functions
...
This allows us to de-duplicate functions
3 years ago
c7b74aa8b4
Remove useless 'locale' argument from error template functions
3 years ago
5e3c9cf290
Remove useless arguments from playlist-related functions
3 years ago
67dd2b419a
db: use prepared statements rather than crafted argument list
3 years ago
df9f897ebe
Fix code broken when extracting data control route
3 years ago
8ef1e81294
Make certain routes ignored if api only
3 years ago
d755d05f88
Move more routes to new pattern
3 years ago
ce4a52325b
db: use now() function instead of passing Time.utc
3 years ago
714a001332
DB: playlists: make that 'insert' never raises
3 years ago
c78f84d5c6
DB: Move integrity check to the base.cr file
3 years ago
a6c9b263da
DB: don't pass PG_DB to check_table/check_enum
3 years ago
5ad2fc64b4
DB: Move a forgotten 'UPDATE channels' statement
3 years ago
2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search
...
Handle invalid channel id in channel: search
3 years ago
c5967ad572
will -> should
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
574e35a720
HTML escape user input
3 years ago
32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments
...
Fix loading reddit comments when there are no threads found
3 years ago
56e505164d
404 error with message and provide example
3 years ago
d4f3139b73
Don't catch and provide better error message instead
3 years ago
97dceb3a5a
Custom error on channel search, handle in search
3 years ago
212f6d6bf5
Fix channel search json parse to not raise
3 years ago
8c2495a399
Apply suggestions from review
3 years ago
9233f71549
Use &.methods where possible instead of curly braces
3 years ago
b2a738cf13
Fix loading reddit comments when there are no threads found
3 years ago
34a79c5f1e
Don't show "next steps" message with a stack trace
...
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
3 years ago
a2600acfa9
Improve crash page messages
...
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
3 years ago
250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus
...
Fix search autofocus
3 years ago
6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import
...
Add CSV Subscriptions Import
3 years ago
6cf6c56dd1
Autofocus search bar only on search homepage
3 years ago
8b72481b8c
Fix comments
...
"ReplyCount" is actually an Int, not a String.
3 years ago
aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales
...
Better support of plurals in locales
3 years ago
eff8b23f57
Improve youtube import type detection
...
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
3 years ago
81a2300af8
Prevent import of insanely large files
3 years ago
fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels
...
Update to fetch related channels again
3 years ago
dc62b6ffdb
Can fetch related channels using just the channel ucid]
3 years ago
eb7e79fdf7
i18n: Apply code review suggestions + code cleaning
3 years ago
37c953e633
i18n: Use plurals for tokens/replies/unseen notifications
3 years ago
5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts
3 years ago
692f4e5be2
i18n: Use plurals for year/month/day/etc...
3 years ago
7bb1471207
i18n: Add dedicated function for counts translation
3 years ago
4752e16ad2
i18n: make multiple fixes to i18next plurals
3 years ago
67d2635e41
i18n: Add i18next plural rules and selector
3 years ago
71a1ad307c
i18n: Add i18next plural resolver class
3 years ago
9a48fd81a3
i18n: Add i18next plurals base sets
3 years ago
790b7afcca
Fix indefinitely growing database
3 years ago
4962c00ba8
Update to fetch related channels again
3 years ago
6764185543
Add explicit return keyword
3 years ago
0a66a68db8
Move require statement to the correct file
3 years ago
8d47ec714e
Add text/xml as a possible mime type for xml file uploads
3 years ago
9607fe03af
Detect the type of subscription import format based on the content type of the file uploaded
3 years ago
62057e676a
Move parse_subscription_export_csv function to user/imports.cr
3 years ago
43ff3be751
Test if body content is likely JSON, if so parse the json format of subscriptions export. If the content is anything else, assume it is CSV and parse
3 years ago
7cbd79fee5
Add helper function parse_subscription_export_csv() which parses the csv format returned by the subscription exporter
3 years ago
5a728243a2
Merge pull request #2767 from SamantazFox/fix-subscriptions-not-cleared
...
Fix subscription not being cleared
3 years ago
2eb7c5c037
PR feedback
3 years ago
ba0bc72d0b
delete_by_playlist_id -> delete_by_playlist
3 years ago
e1219cbdef
Fix playlist deletion
3 years ago
bf0a48847c
DB: fix subscription not being cleared
...
Fixes https://github.com/iv-org/invidious/issues/2764
3 years ago
3bb7fbb2f1
Merge pull request #2719 from SamantazFox/batch-minor-fixes
...
Multiple minor fixes
3 years ago
326a362eb8
Merge pull request #2685 from SamantazFox/database-improvments
...
Database improvements
3 years ago
fdc380e7f7
Merge pull request #2677 from SamantazFox/decompression-fix-2
...
Temporarily fix for #2612 (round 2)
3 years ago
444b1c99d0
Show unavailable videos in playlists
3 years ago
3b1a286290
Use dig?() for playlist title
3 years ago
6c8a5a1e7f
Fix leading spaces being collapsed in descriptions
...
Fixes #1954
3 years ago
1769b0fdce
Fix "video can't be added to playlist without JS"
...
Fixes #2686
3 years ago
68cbc11810
Fix the search box
...
Fix #277 : autoselect search field
Fix #1107 : no spell checking/auto-correct on search field
3 years ago
302fecbdcb
Clean useless database arguments (5/5)
3 years ago
d74873fed1
Clean useless database arguments (4/5)
3 years ago
40ed4a0506
Clean useless database arguments (3/5)
3 years ago
c25d664edc
Clean useless database arguments (2/5)
3 years ago
9bad7e2940
Clean useless database arguments (1/5)
3 years ago
6704ce3214
Move DB utility functions to the proper module
3 years ago
914cfbd953
Move DB queries related to 'annotations' in a separate module
3 years ago
85cf27119c
Move DB queries related to playlists in a separate module (3/3)
3 years ago
7691f53520
Move DB queries related to 'users' in a separate module (2/2)
3 years ago
094f835642
Move DB queries related to 'users' in a separate module (1/2)
3 years ago
92eea3b18b
Move DB queries related to session tokens in a separate module
3 years ago
c021b93b5c
Move DB queries related to channels in a separate module
3 years ago
d94d4c2045
Move DB queries related to statistics in a separate module
3 years ago
46d08237c6
Move DB queries related to playlists in a separate module (2/3)
3 years ago
3deafe9f8d
Move DB queries related to playlists in a separate module (1/3)
3 years ago
998edba6f0
Move DB queries related to 'videos' in a separate module
3 years ago
a779cdd463
Merge pull request #2727 from SamantazFox/add-shorts-support
...
Add support for shorts
3 years ago
fc2b9031d4
i18n: Add Serbian back
3 years ago
28a6589a1e
Merge pull request #2538 from bbielsa/player-remember-position
...
Retain video time position in video player
3 years ago
ddb06b0cac
Fix XSS vulnerability in channel playlists
...
The channel/<ucid>/playlists page was vulnerable to Cross Site Scripting
(XSS), because the different URL parameters were inserted as-is in the URL
meant for instance switching.
This vulnerability could allow an attacker to inject malicious Javascript
in the page by tricking the user to click on a crafted link.
Bug introduced in commit 66e7285108
3 years ago
f54e247eb4
Extractors: Add support for shorts
...
Fixes #2708
3 years ago
b90bceb2dc
Fix formatting of preferences.cr and videos.cr
3 years ago
f31bd5ffb9
Use localization for save player position label in the preferences page
3 years ago
5abe7fe123
Rename 'remember_position' to 'save_player_pos' for clarity
3 years ago
a6a0bbf398
Add remember_position field to the Preferences and VideoPreferences structs, and add a checkbox in the preferences page to toggle it
3 years ago
ee91effb7a
Merge pull request #2576 from SamantazFox/fix-locales-handling
...
Fix locales handling
3 years ago
f236a6872b
Merge pull request #2659 from SamantazFox/fix-likes-dislikes
...
Fix likes/dislikes
3 years ago
3e0096f360
Merge pull request #2683 from iv-org/SamantazFox-patch-1
...
Fix #2682
3 years ago
438b334320
Merge pull request #2671 from matthewmcgarvey/code-removal
...
Remove dead code
3 years ago
4aa96ecab9
Use 'dig()' in 'find()' statements
3 years ago
7b9d26d688
Fix #2670
...
Fixes "Download widget replaces spaces in filename with +"
https://github.com/iv-org/invidious/issues/2670
3 years ago
8d4b4cd14c
Remove dead code
3 years ago
342fc202a7
Fix #2682
...
Fix "Missing param name: "q" (KeyError)"
https://github.com/iv-org/invidious/issues/2682
3 years ago
4436359d07
Use dig to get category contents
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
91f8395222
Typo: missing '?' when looking for key in dislikes_button
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
de00e86cd5
Decompress the response body ourselves
...
Temp fix for #2612
3 years ago
c6e086c6ff
Revert "Temporarily fix for #2612" ( #2673 )
3 years ago
82f3eda82b
Merge pull request #2656 from SamantazFox/fix-2549
...
extract_video_info: Make sure that the Android player response is valid
3 years ago
05f9613e14
Merge pull request #2623 from SamantazFox/temp-decompression-fix
...
Temporarily fix for #2612
3 years ago
ceb1feb350
likes/dislikes: better fallback management
...
'.to_i64?' instead of '.to_i64' returns nil rather than raising
an exception when it's done on an empty string.
In some rare cases, rating can be equal to 5. In this case, the
value of player_response[videoDetails][averageRating] is an
Int and not a Float.
3 years ago
2ea0590b03
i18n: return 'key' if 'key' is not in locales files
3 years ago
80a513baa5
Use new techniques to get (dis)likes back
3 years ago
ba48f68fc3
allow multiple, successive content-encodings
3 years ago
319587e2f1
extract_video_info: make sure that the Android player response is valid
3 years ago
bf7952d9c7
i18n: log a warning instead of rising an exception
...
This is more user-friendly.
TODO: maybe make a compile time flag for testing purposes
3 years ago
f29ab53aff
Add other missing translations
...
* on watch page and video cards (search results, playlists, etc...)
* on /feed/playlists
* in search filters (not normalized in order to avoid collisions with
an existing PR that reworks the search filters)
3 years ago
b5b0c58de7
Add missing translation for quality selectors
3 years ago
a1bb421eec
Remove useless 'hl' parameters on captions URL
3 years ago
139786b9ef
i18n: pass only the ISO code string to 'translate()'
...
Don't use the whole Hash everywhere.
Also fall back nicely to english string if no translation exists.
3 years ago
301444563b
i18n: Use language full name instead of ISO code
...
Fixes #851
3 years ago
9966c21c6b
i18n: Add list of language names
3 years ago
fd54cf2d05
Escape video description
3 years ago
2c447a42f2
Make sure to only apply fix if QUIC is disabled
3 years ago
dad8f9a0ce
Fix typo
...
Should be checking the returned headers, not the sent ones.
3 years ago
2eac23a0b3
Temporary fix for #2612
...
Don't rely on the auto compression/decompression provided by the crystal stdlib.
3 years ago
00904ae3f2
Merge pull request #2444 from syeopite/only-use-redirect-endpoint-when-needed
...
Only use the /redirect endpoint when automatically redirecting to another instance
3 years ago
d214a0b333
remove duplicate lsquic requirement
3 years ago
a120f143d7
Disable quic by default
...
See #2577
3 years ago
65fbdbff6a
Remove of gzip header w/ use_quic config
...
Continuation of b0f127d4d8
3 years ago
6ec4dcfafd
Fix handling for maxres thumbnail
3 years ago
48191aca6e
Fix copy-paste error
3 years ago
83556bace2
Allow thumbnail queries with QUIC disabled
3 years ago
814c9e6c3a
Use https for storyboard image requests
3 years ago
547abe17d9
Use https for ggpht requests
3 years ago
6b8450558d
Allow storyboard queries with QUIC disabled
3 years ago
c3747c2d49
Allow ggpht queries with QUIC disabled
3 years ago
245122104a
Respect use_quic param and fix typos
3 years ago
b0f127d4d8
Fix gzip decompression with HTTP::Client
3 years ago
d379a36c0e
Add compile-time flag to remove code for QUIC
3 years ago
6cf0ff6b49
Remove useless auto_generated param from PlaylistVideo#to_xml
...
given the variables available in this function's context, 'author' and 'ucid'
provide the same data 'self.author' and 'self.ucid', respectively.
Given that fact, the variable `auto_generated` has no impact on the logic of
this function, and hence can be safely removed. this greatly simplifies the
code and makes it perfectly compatible with crystal's calling convention for
'#to_xml' methods.
3 years ago
86f75758a7
Fix 'to_json' in struct PlaylistVideo
3 years ago
0ec94405ce
Add TODO comments to other places
3 years ago
33780f1995
Also fix 'to_json' in struct Video
3 years ago
1cb715ac9f
serialized_yt_data: force datatype of 'locale'
3 years ago
f65b628bf3
serialized_yt_data: Remove default nil value in to_json
...
this will ensure that two parameters are passed and that it
doesn't collide with 'to_json(builder)'
3 years ago
60fa552469
Fix an infinite recursion caused by #2228
...
Changes in the aforementioned PR lead to change the behavior
of some old code.
The data type of the parameters aren't explicit enough, which
makes the compiler use the wrong method because of type infering.
3 years ago
437bdedb07
Use env.request.resource for instance switch link
3 years ago
a531f4f057
Rebase error
3 years ago
bb396a310e
Remove unneeded redirect.invidious.io code in /redirect
3 years ago
66e7285108
Only use /redirect when automatically redirecting
3 years ago
2b81a82620
Merge pull request #2529 from DmitrySandalov/master
...
Feature Request: Localization for trending iv-org#331
3 years ago
b555df8377
Merge pull request #2428 from syeopite/ameba-fixes
...
Fix (some) issues detected by Ameba
3 years ago
232730e909
Merge branch 'master' into master
3 years ago
1e0712625a
Normalize translation key for preferences categories
...
categories normalized:
- Miscellanous
- Player
- Visual
- Administrator
- Data
- Subscription
3 years ago
88752f32bd
Normalize translation key for user prefrerences
...
preferences normalized:
- annotations
- annotations_subscribed
- automatic_instance_redirect
- autoplay
- captions
- comments
- continue
- continue_autoplay
- dark_mode
- default_home
- extend_desc
- feed_menu
- listen
- local
- locale
- max_results
- notifications_only
- player_style
- quality
- quality_dash
- related_videos
- show_nick
- sort
- speed
- thin_mode
- unseen_only
- video_loop
- volume
- vr_mode
3 years ago
e2bbc9a6fa
Switch to #sort_by! in pull_popular_videos job
3 years ago
17e481c107
Reduce block verbosity further
3 years ago
b8f27a42a7
Optimize assigning of on_response_received_endpoints
3 years ago
575c66efd3
Remove extra dot between [] from ambea copy-pasting.
3 years ago
88ad7c8d8d
Update src/invidious/routes/playlists.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
1adcac175e
Update src/invidious/routes/channels.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
dd8c412abc
Fix Style/IsAFilter issues
3 years ago
e969c1490a
Fix Performance/ChainedCallWithNoBang issues
3 years ago
e91421253e
Fix Style/VerboseBlock issues
3 years ago
35d15c7c2b
Fix Style/VariableNames issues
3 years ago
20cb751ff6
Fix Lint/UnusedArgument issues
3 years ago
0614b52f03
Fix Lint/RedundantStringCoercion issues
3 years ago
a629521c37
Feature Request: Localization for trending (remove region from server config)
3 years ago
0e17d026f2
Feature Request: Localization for trending (fix lint CONTENT_REGIONS end comma)
3 years ago
1d78d67af3
Feature Request: Localization for trending (move TRENDING_REGIONS to i18n.cr as CONTENT_REGIONS)
3 years ago
d9c58c4837
Feature Request: Localization for trending iv-org#331
3 years ago
129779a757
Merge pull request #2433 from iv-org/increase-channel-refresh-delay
...
Decrease channel refresh frequency (1 min -> 1 h)
3 years ago
c8a985cc77
Merge pull request #2477 from SamantazFox/move-prefs-and-config
...
Move user preferences and server config
3 years ago
cb9b84f940
Move 'extract_text()' to 'extractors_utils.cr'
3 years ago
33d9be0ffb
Move 'extractors.cr' to 'yt_backend' folder
3 years ago
2571e420f3
Move 'add_yt_headers()' to 'connection_pool.cr'
3 years ago
e17c8b1f4d
Move 'extract_videos' and 'extract_selected_tab' too
3 years ago
8805ee7c8c
Add fetch_continuation_token back (required by #2215 )
3 years ago
Samantaz Fox