8af202e86b
Merge pull request #2892 from matthewmcgarvey/video-playability
...
Raise error if video not playable, also handle missing related videos
3 years ago
57353fe0c6
Fix Freetube subscriptions import
3 years ago
60e870b277
Fix OPML import
3 years ago
bf054dfda5
Do not check for pending migrations on app start
...
This is so that we don't break deploys with this PR.
Instead we only ship the 'invidious --migrate' cli command
and let people test that. Maybe even ship a new migration that wouldn't break
apps that don't run the migrations. Then we roll out the functionality
that requires migrations.
3 years ago
59654289cb
Run migrations through CLI instead of when app starts
3 years ago
cf13c11236
Migrations tweaks
3 years ago
ddf1e84f7c
Raise exception if playability not ok, also handle missing related videos
3 years ago
01135db80a
video_playback: Check "host" parameter validity
3 years ago
cdd473e195
DB: fix inverted arguments in User.update_password()
...
Closes https://github.com/iv-org/invidious/issues/2875
3 years ago
da10cdd5ab
Merge pull request #2872 from SamantazFox/misaligned-captions
...
Use a regex to fix badly aligned captions
3 years ago
8ec992a8a3
Add custom migration implementation
3 years ago
ec55b905cb
Fix empty error page on BrokenTubeException
3 years ago
492d1144e0
Apply changes from code review
3 years ago
4f4b19a962
embed page: fix typo in videojs-overlay script URL
3 years ago
febd785428
Add missing subtitle languages
3 years ago
76cc8ac66b
HTML escape error message
3 years ago
f73aef33f0
Add compile option to disable fetching of player dependencies
3 years ago
d12dff9dcf
Use a regex to fix badly aligned captions
3 years ago
99d770be64
Move user pages (ECR files) to subfolder
3 years ago
71a8867a4a
Move user cookies to their own module
3 years ago
2bbd424fce
Move import logic to its own module
3 years ago
ef8dc7272b
Put CSV import function under its own module
3 years ago
ad4a06fca5
Move user captcha code to its own module
3 years ago
c04f45d5e3
Move user struct to own file, under Invidious namespace
3 years ago
fb36155022
Move user routes definitions to a macro in routing.cr
3 years ago
7ace3fc989
Move remaining user-related routes out of main file
3 years ago
170e754998
Merge pull request #2868 from SamantazFox/related-channels-items-fix
...
Related channel may contain a continuation entry
3 years ago
6a75fa08dc
Merge pull request #2492 from mastihios/patch-input-html-escape
...
Change <input value="..."> encoding to HTML.escape
3 years ago
7e4690e43c
Fix typos
3 years ago
f8b29674b2
Gave them marks some space and added nil checks
3 years ago
fe55141a7b
Crystal format
3 years ago
9205ccc124
Removed dummy values and added checks for items.ecr
3 years ago
698a6f3886
API: handle related channels parsing exceptions
3 years ago
1668e4187e
Related channel may contain a continuation entry
3 years ago
00df3e2c40
Refactored code and added badges to Search but many dummies because of the way components/item works
3 years ago
a2578ac6b4
Added Verified Badge to related videos
3 years ago
1fee636afa
Added verification badge to video player and error with related_videos
3 years ago
154bca4635
Added Verification Badge to Youtube Comments
3 years ago
c584e31657
Inlined the if statement
3 years ago
66340281e6
Added verification badge for channel view
3 years ago
ba37259258
Also propagate changes to watch ECR page
3 years ago
eca8d2e7d7
Apply suggestions from code review
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
cb0f7bf6b0
Change <input value="..."> encoding to HTML.escape
3 years ago
1ec15dc073
Propagate related videos changes to API function
3 years ago
f124e8cf93
Fix parsing of related videos
3 years ago
9621175dc9
extractors: Add helper for short view count text
3 years ago
e6ddd6d6c1
make HelperExtractors non-private
3 years ago
d7ebd763f5
video parsing: add secondary_results root element
3 years ago
99091e919c
video parsing: raise if major root element is missing
3 years ago
6ddbccbc95
Add new exception for parsing issues
3 years ago
4e44a91d08
Add support for clips
3 years ago
fc5f84a0cd
Merge pull request #2827 from SamantazFox/more-code-cleanup
...
More code cleanup
3 years ago
d546f1870e
Merge pull request #2845 from SamantazFox/more-db-improvements
...
More db improvements
3 years ago
f5cb7ba96c
Merge pull request #2833 from matthewmcgarvey/get-channel-cleanup
...
Channel helpers cleanup
3 years ago
519c227c4f
Use short syntax for 'File.open' block
3 years ago
6f4665588f
search.cr: use do/end rather than inline {} block
3 years ago
eba311baa9
Merge pull request #2397 from syeopite/dep-manager-for-videojs-stuff
...
Add dependency manager script for videojs stuff
3 years ago
e92b3779ad
Add back in refreshing of channels every 2 days
3 years ago
a82d21ff78
Cleanup channel helpers code
3 years ago
63e1165936
videos.cr: use '.dig?()' where possible
3 years ago
84cc732281
search functions: Don't return result count
...
This is useless, as the items count can be directly acessed
using the '.size' method, so use that instead when needed.
3 years ago
971b6ec96f
Fix 'Lint/UselessAssign' warnings reported by ameba
3 years ago
46f7ca9ffa
Remove useless intermediary variable in youtube_api.cr
...
This fixes an ameba warning
3 years ago
dee20f92a7
Avoid infinite loop in ChannelVideo's to_xml/to_json methods
3 years ago
12b818a83c
Fix more 'Lint/ShadowingOuterLocalVar' warnings reported by ameba
3 years ago
1c91110464
Fix some 'Lint/ShadowingOuterLocalVar' warnings reported by ameba
3 years ago
4cd7a3e83f
Remove useless 'locale = env.get...' from many routes
3 years ago
fa99c9aa85
Use '.dig?()' in playlist parsing
3 years ago
2d949834e9
Make 'additional_fields' optional in JSON error template functions
...
This allows us to de-duplicate functions
3 years ago
c7b74aa8b4
Remove useless 'locale' argument from error template functions
3 years ago
5e3c9cf290
Remove useless arguments from playlist-related functions
3 years ago
67dd2b419a
db: use prepared statements rather than crafted argument list
3 years ago
df9f897ebe
Fix code broken when extracting data control route
3 years ago
8ef1e81294
Make certain routes ignored if api only
3 years ago
d755d05f88
Move more routes to new pattern
3 years ago
ce4a52325b
db: use now() function instead of passing Time.utc
3 years ago
714a001332
DB: playlists: make that 'insert' never raises
3 years ago
c78f84d5c6
DB: Move integrity check to the base.cr file
3 years ago
a6c9b263da
DB: don't pass PG_DB to check_table/check_enum
3 years ago
5ad2fc64b4
DB: Move a forgotten 'UPDATE channels' statement
3 years ago
2ae074a9a4
Merge pull request #2821 from matthewmcgarvey/channel-search
...
Handle invalid channel id in channel: search
3 years ago
c5967ad572
will -> should
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
574e35a720
HTML escape user input
3 years ago
32ae38b933
Merge pull request #2822 from matthewmcgarvey/reddit-comments
...
Fix loading reddit comments when there are no threads found
3 years ago
56e505164d
404 error with message and provide example
3 years ago
d4f3139b73
Don't catch and provide better error message instead
3 years ago
97dceb3a5a
Custom error on channel search, handle in search
3 years ago
212f6d6bf5
Fix channel search json parse to not raise
3 years ago
8c2495a399
Apply suggestions from review
3 years ago
9233f71549
Use &.methods where possible instead of curly braces
3 years ago
b2a738cf13
Fix loading reddit comments when there are no threads found
3 years ago
34a79c5f1e
Don't show "next steps" message with a stack trace
...
Usually, next steps are after the error message.
Here, we want the same options to be right above the stack trace,
so users are less likely to report duplicates.
3 years ago
a2600acfa9
Improve crash page messages
...
* Ask to read the FAQ and search for existing issues on Github
* Include links to FAQ and directly to a new github issue
* Github issue title is automatically based on exception name
* Improved HTML
* Minor languages changes
3 years ago
250a9191cb
Merge pull request #2814 from SamantazFox/fix-search-autofocus
...
Fix search autofocus
3 years ago
6fab5d0554
Merge pull request #2545 from bbielsa/csv-subscriptions-import
...
Add CSV Subscriptions Import
3 years ago
6cf6c56dd1
Autofocus search bar only on search homepage
3 years ago
8b72481b8c
Fix comments
...
"ReplyCount" is actually an Int, not a String.
3 years ago
aa0724f204
Merge pull request #2646 from SamantazFox/support-plurals-in-locales
...
Better support of plurals in locales
3 years ago
eff8b23f57
Improve youtube import type detection
...
Code courtesy of bbielsa:
https://gist.github.com/bbielsa/7d131aa2188945f591a8379ec0defc9b
3 years ago
81a2300af8
Prevent import of insanely large files
3 years ago
fb673639f9
Merge pull request #2787 from matthewmcgarvey/related-channels
...
Update to fetch related channels again
3 years ago
dc62b6ffdb
Can fetch related channels using just the channel ucid]
3 years ago
eb7e79fdf7
i18n: Apply code review suggestions + code cleaning
3 years ago
37c953e633
i18n: Use plurals for tokens/replies/unseen notifications
3 years ago
5bb2cb7d71
i18n: Use plurals for video/view/subscriber/subscription counts
3 years ago
692f4e5be2
i18n: Use plurals for year/month/day/etc...
3 years ago
7bb1471207
i18n: Add dedicated function for counts translation
3 years ago
4752e16ad2
i18n: make multiple fixes to i18next plurals
3 years ago
67d2635e41
i18n: Add i18next plural rules and selector
3 years ago
71a1ad307c
i18n: Add i18next plural resolver class
3 years ago
9a48fd81a3
i18n: Add i18next plurals base sets
3 years ago
790b7afcca
Fix indefinitely growing database
3 years ago
4962c00ba8
Update to fetch related channels again
3 years ago
6764185543
Add explicit return keyword
3 years ago
0a66a68db8
Move require statement to the correct file
3 years ago
8d47ec714e
Add text/xml as a possible mime type for xml file uploads
3 years ago
9607fe03af
Detect the type of subscription import format based on the content type of the file uploaded
3 years ago
62057e676a
Move parse_subscription_export_csv function to user/imports.cr
3 years ago
43ff3be751
Test if body content is likely JSON, if so parse the json format of subscriptions export. If the content is anything else, assume it is CSV and parse
3 years ago
7cbd79fee5
Add helper function parse_subscription_export_csv() which parses the csv format returned by the subscription exporter
3 years ago
5a728243a2
Merge pull request #2767 from SamantazFox/fix-subscriptions-not-cleared
...
Fix subscription not being cleared
3 years ago
2eb7c5c037
PR feedback
3 years ago
ba0bc72d0b
delete_by_playlist_id -> delete_by_playlist
3 years ago
e1219cbdef
Fix playlist deletion
3 years ago
bf0a48847c
DB: fix subscription not being cleared
...
Fixes https://github.com/iv-org/invidious/issues/2764
3 years ago
3bb7fbb2f1
Merge pull request #2719 from SamantazFox/batch-minor-fixes
...
Multiple minor fixes
3 years ago
326a362eb8
Merge pull request #2685 from SamantazFox/database-improvments
...
Database improvements
3 years ago
fdc380e7f7
Merge pull request #2677 from SamantazFox/decompression-fix-2
...
Temporarily fix for #2612 (round 2)
3 years ago
444b1c99d0
Show unavailable videos in playlists
3 years ago
3b1a286290
Use dig?() for playlist title
3 years ago
6c8a5a1e7f
Fix leading spaces being collapsed in descriptions
...
Fixes #1954
3 years ago
1769b0fdce
Fix "video can't be added to playlist without JS"
...
Fixes #2686
3 years ago
68cbc11810
Fix the search box
...
Fix #277 : autoselect search field
Fix #1107 : no spell checking/auto-correct on search field
3 years ago
302fecbdcb
Clean useless database arguments (5/5)
3 years ago
d74873fed1
Clean useless database arguments (4/5)
3 years ago
40ed4a0506
Clean useless database arguments (3/5)
3 years ago
c25d664edc
Clean useless database arguments (2/5)
3 years ago
9bad7e2940
Clean useless database arguments (1/5)
3 years ago
6704ce3214
Move DB utility functions to the proper module
3 years ago
914cfbd953
Move DB queries related to 'annotations' in a separate module
3 years ago
85cf27119c
Move DB queries related to playlists in a separate module (3/3)
3 years ago
7691f53520
Move DB queries related to 'users' in a separate module (2/2)
3 years ago
094f835642
Move DB queries related to 'users' in a separate module (1/2)
3 years ago
92eea3b18b
Move DB queries related to session tokens in a separate module
3 years ago
c021b93b5c
Move DB queries related to channels in a separate module
3 years ago
d94d4c2045
Move DB queries related to statistics in a separate module
3 years ago
46d08237c6
Move DB queries related to playlists in a separate module (2/3)
3 years ago
3deafe9f8d
Move DB queries related to playlists in a separate module (1/3)
3 years ago
998edba6f0
Move DB queries related to 'videos' in a separate module
3 years ago
a779cdd463
Merge pull request #2727 from SamantazFox/add-shorts-support
...
Add support for shorts
3 years ago
fc2b9031d4
i18n: Add Serbian back
3 years ago
28a6589a1e
Merge pull request #2538 from bbielsa/player-remember-position
...
Retain video time position in video player
3 years ago
ddb06b0cac
Fix XSS vulnerability in channel playlists
...
The channel/<ucid>/playlists page was vulnerable to Cross Site Scripting
(XSS), because the different URL parameters were inserted as-is in the URL
meant for instance switching.
This vulnerability could allow an attacker to inject malicious Javascript
in the page by tricking the user to click on a crafted link.
Bug introduced in commit 66e7285108
3 years ago
f54e247eb4
Extractors: Add support for shorts
...
Fixes #2708
3 years ago
b90bceb2dc
Fix formatting of preferences.cr and videos.cr
3 years ago
f31bd5ffb9
Use localization for save player position label in the preferences page
3 years ago
5abe7fe123
Rename 'remember_position' to 'save_player_pos' for clarity
3 years ago
a6a0bbf398
Add remember_position field to the Preferences and VideoPreferences structs, and add a checkbox in the preferences page to toggle it
3 years ago
ee91effb7a
Merge pull request #2576 from SamantazFox/fix-locales-handling
...
Fix locales handling
3 years ago
f236a6872b
Merge pull request #2659 from SamantazFox/fix-likes-dislikes
...
Fix likes/dislikes
3 years ago
3e0096f360
Merge pull request #2683 from iv-org/SamantazFox-patch-1
...
Fix #2682
3 years ago
438b334320
Merge pull request #2671 from matthewmcgarvey/code-removal
...
Remove dead code
3 years ago
4aa96ecab9
Use 'dig()' in 'find()' statements
3 years ago
7b9d26d688
Fix #2670
...
Fixes "Download widget replaces spaces in filename with +"
https://github.com/iv-org/invidious/issues/2670
3 years ago
8d4b4cd14c
Remove dead code
3 years ago
342fc202a7
Fix #2682
...
Fix "Missing param name: "q" (KeyError)"
https://github.com/iv-org/invidious/issues/2682
3 years ago
4436359d07
Use dig to get category contents
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
91f8395222
Typo: missing '?' when looking for key in dislikes_button
...
Co-authored-by: Matthew McGarvey <matthewmcgarvey14@gmail.com>
3 years ago
de00e86cd5
Decompress the response body ourselves
...
Temp fix for #2612
3 years ago
c6e086c6ff
Revert "Temporarily fix for #2612" ( #2673 )
3 years ago
82f3eda82b
Merge pull request #2656 from SamantazFox/fix-2549
...
extract_video_info: Make sure that the Android player response is valid
3 years ago
05f9613e14
Merge pull request #2623 from SamantazFox/temp-decompression-fix
...
Temporarily fix for #2612
3 years ago
ceb1feb350
likes/dislikes: better fallback management
...
'.to_i64?' instead of '.to_i64' returns nil rather than raising
an exception when it's done on an empty string.
In some rare cases, rating can be equal to 5. In this case, the
value of player_response[videoDetails][averageRating] is an
Int and not a Float.
3 years ago
2ea0590b03
i18n: return 'key' if 'key' is not in locales files
3 years ago
80a513baa5
Use new techniques to get (dis)likes back
3 years ago
ba48f68fc3
allow multiple, successive content-encodings
3 years ago
319587e2f1
extract_video_info: make sure that the Android player response is valid
3 years ago
bf7952d9c7
i18n: log a warning instead of rising an exception
...
This is more user-friendly.
TODO: maybe make a compile time flag for testing purposes
3 years ago
f29ab53aff
Add other missing translations
...
* on watch page and video cards (search results, playlists, etc...)
* on /feed/playlists
* in search filters (not normalized in order to avoid collisions with
an existing PR that reworks the search filters)
3 years ago
b5b0c58de7
Add missing translation for quality selectors
3 years ago
a1bb421eec
Remove useless 'hl' parameters on captions URL
3 years ago
139786b9ef
i18n: pass only the ISO code string to 'translate()'
...
Don't use the whole Hash everywhere.
Also fall back nicely to english string if no translation exists.
3 years ago
301444563b
i18n: Use language full name instead of ISO code
...
Fixes #851
3 years ago
9966c21c6b
i18n: Add list of language names
3 years ago
fd54cf2d05
Escape video description
3 years ago
2c447a42f2
Make sure to only apply fix if QUIC is disabled
3 years ago
dad8f9a0ce
Fix typo
...
Should be checking the returned headers, not the sent ones.
3 years ago
2eac23a0b3
Temporary fix for #2612
...
Don't rely on the auto compression/decompression provided by the crystal stdlib.
3 years ago
00904ae3f2
Merge pull request #2444 from syeopite/only-use-redirect-endpoint-when-needed
...
Only use the /redirect endpoint when automatically redirecting to another instance
3 years ago
d214a0b333
remove duplicate lsquic requirement
3 years ago
a120f143d7
Disable quic by default
...
See #2577
3 years ago
65fbdbff6a
Remove of gzip header w/ use_quic config
...
Continuation of b0f127d4d8
3 years ago
6ec4dcfafd
Fix handling for maxres thumbnail
3 years ago
48191aca6e
Fix copy-paste error
3 years ago
83556bace2
Allow thumbnail queries with QUIC disabled
3 years ago
814c9e6c3a
Use https for storyboard image requests
3 years ago
547abe17d9
Use https for ggpht requests
3 years ago
6b8450558d
Allow storyboard queries with QUIC disabled
3 years ago
c3747c2d49
Allow ggpht queries with QUIC disabled
3 years ago
245122104a
Respect use_quic param and fix typos
3 years ago
b0f127d4d8
Fix gzip decompression with HTTP::Client
3 years ago
d379a36c0e
Add compile-time flag to remove code for QUIC
3 years ago
6cf0ff6b49
Remove useless auto_generated param from PlaylistVideo#to_xml
...
given the variables available in this function's context, 'author' and 'ucid'
provide the same data 'self.author' and 'self.ucid', respectively.
Given that fact, the variable `auto_generated` has no impact on the logic of
this function, and hence can be safely removed. this greatly simplifies the
code and makes it perfectly compatible with crystal's calling convention for
'#to_xml' methods.
3 years ago
86f75758a7
Fix 'to_json' in struct PlaylistVideo
3 years ago
0ec94405ce
Add TODO comments to other places
3 years ago
33780f1995
Also fix 'to_json' in struct Video
3 years ago
1cb715ac9f
serialized_yt_data: force datatype of 'locale'
3 years ago
f65b628bf3
serialized_yt_data: Remove default nil value in to_json
...
this will ensure that two parameters are passed and that it
doesn't collide with 'to_json(builder)'
3 years ago
60fa552469
Fix an infinite recursion caused by #2228
...
Changes in the aforementioned PR lead to change the behavior
of some old code.
The data type of the parameters aren't explicit enough, which
makes the compiler use the wrong method because of type infering.
3 years ago
437bdedb07
Use env.request.resource for instance switch link
3 years ago
a531f4f057
Rebase error
3 years ago
bb396a310e
Remove unneeded redirect.invidious.io code in /redirect
3 years ago
66e7285108
Only use /redirect when automatically redirecting
3 years ago
2b81a82620
Merge pull request #2529 from DmitrySandalov/master
...
Feature Request: Localization for trending iv-org#331
3 years ago
b555df8377
Merge pull request #2428 from syeopite/ameba-fixes
...
Fix (some) issues detected by Ameba
3 years ago
232730e909
Merge branch 'master' into master
3 years ago
1e0712625a
Normalize translation key for preferences categories
...
categories normalized:
- Miscellanous
- Player
- Visual
- Administrator
- Data
- Subscription
3 years ago
88752f32bd
Normalize translation key for user prefrerences
...
preferences normalized:
- annotations
- annotations_subscribed
- automatic_instance_redirect
- autoplay
- captions
- comments
- continue
- continue_autoplay
- dark_mode
- default_home
- extend_desc
- feed_menu
- listen
- local
- locale
- max_results
- notifications_only
- player_style
- quality
- quality_dash
- related_videos
- show_nick
- sort
- speed
- thin_mode
- unseen_only
- video_loop
- volume
- vr_mode
3 years ago
e2bbc9a6fa
Switch to #sort_by! in pull_popular_videos job
3 years ago
17e481c107
Reduce block verbosity further
3 years ago
b8f27a42a7
Optimize assigning of on_response_received_endpoints
3 years ago
575c66efd3
Remove extra dot between [] from ambea copy-pasting.
3 years ago
88ad7c8d8d
Update src/invidious/routes/playlists.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
1adcac175e
Update src/invidious/routes/channels.cr
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
dd8c412abc
Fix Style/IsAFilter issues
3 years ago
e969c1490a
Fix Performance/ChainedCallWithNoBang issues
3 years ago
e91421253e
Fix Style/VerboseBlock issues
3 years ago
35d15c7c2b
Fix Style/VariableNames issues
3 years ago
20cb751ff6
Fix Lint/UnusedArgument issues
3 years ago
0614b52f03
Fix Lint/RedundantStringCoercion issues
3 years ago
a629521c37
Feature Request: Localization for trending (remove region from server config)
3 years ago
0e17d026f2
Feature Request: Localization for trending (fix lint CONTENT_REGIONS end comma)
3 years ago
1d78d67af3
Feature Request: Localization for trending (move TRENDING_REGIONS to i18n.cr as CONTENT_REGIONS)
3 years ago
d9c58c4837
Feature Request: Localization for trending iv-org#331
3 years ago
129779a757
Merge pull request #2433 from iv-org/increase-channel-refresh-delay
...
Decrease channel refresh frequency (1 min -> 1 h)
3 years ago
c8a985cc77
Merge pull request #2477 from SamantazFox/move-prefs-and-config
...
Move user preferences and server config
3 years ago
cb9b84f940
Move 'extract_text()' to 'extractors_utils.cr'
3 years ago
33d9be0ffb
Move 'extractors.cr' to 'yt_backend' folder
3 years ago
2571e420f3
Move 'add_yt_headers()' to 'connection_pool.cr'
3 years ago
e17c8b1f4d
Move 'extract_videos' and 'extract_selected_tab' too
3 years ago
8805ee7c8c
Add fetch_continuation_token back (required by #2215 )
3 years ago
7df2fd0bc8
Add 'require' statement to 'invidious.cr'
3 years ago
f7f0910953
Remove fetch_continuation_token(): dead code
3 years ago
d300797e22
Move the YoutubeConnectionPool code to its own file
3 years ago
56dbe15943
Move proxy & YoutubeAPI code to the yt_backend folder
3 years ago
5f65e92500
Merge pull request #2508 from syeopite/lazy-load-images
...
Lazy load (some) images
3 years ago
21b96a3159
Merge pull request #2506 from syeopite/handle-empty-playlist-tabs
...
Handle YT tabs without content
3 years ago
888c7e2c29
Merge pull request #2491 from syeopite/extract-image-routes
...
Extract image routes
3 years ago
22e8f7e287
Fix #2510
3 years ago
0ad2793b68
Link to invidious.io/donate/ in the footer
3 years ago
585e4617e8
Lazy load (some) images
3 years ago
4d44b2c3a4
Handle YT tabs without any content
3 years ago
b49b5fbda9
Support empty categories
3 years ago
17e6093abb
Merge pull request #2497 from Yetangitu/videorendererparser_parse_missing_title
...
Handle missing title fields in VideoRendererParser.parse (fixes #2495 )
3 years ago
3dc980e800
Fix for #2488 - parse contents of search results of type=Category ( #2496 )
...
* Fix for #2488 - parse contents of search results of type=Category (returned on first page for universal (type=all) queries instead of returning an error.
* Moved content array walker to Category#to_json
As requested by reviewer this change moves the content array walker from the API endpoint to the Category class.
* Update src/invidious/helpers/serialized_yt_data.cr
Co-authored-by: syeopite <70992037+syeopite@users.noreply.github.com>
3 years ago
c44c1003af
Handle missing title fields in VideoRendererParser.parse
3 years ago
678b10dbcf
Lookback 50 videos
3 years ago
a1d6411f1f
propagate video_id field on getting playlists
3 years ago
c4c8a10507
rename from continuation to video_id on get_playlist_videos
3 years ago
ee94ccdeb0
update to new YoutubeAPI
3 years ago
e3df9f9ead
use dig for getting the video index
3 years ago
62dc629337
linting
3 years ago
dccdf38ce7
increase the max videos in a playlist
3 years ago
84124b837d
use v1/next instead of searching for the continuation index
3 years ago
6176da3cbb
linting
3 years ago
24bc3e2704
no need to normalize the offset
3 years ago
0a9e19646a
pass the api/v1/playlists with videos before the offset
3 years ago
65e45c4079
linting
3 years ago
440105976f
fix cases when high offset video from playlist has no offset in url
3 years ago
7eba7fbcc7
add index to playlist item
3 years ago
d9bfb3d305
playlist starts at the offset
3 years ago
4246c7a523
Extract image routes
3 years ago
57ed047025
Add mising 'require' statement to 'invidious.cr'
3 years ago
bda3a26423
Move server structure to a separate file
3 years ago
080d9a8dc7
move theme converter function to a separate file
3 years ago
984a4acc7b
Move user preferences structure to a separate file
3 years ago
b10f37bea9
Use kemal in production mode ( #2455 )
3 years ago
0947c26612
Fix URL-encoding in href strings ( #2460 )
...
* hrefs: replace HTML.escape w/ URI.encode_www_form
* Fix search_query_encoded
3 years ago
c6f088d6ca
Reduce refresh delay, increase backoff start duration
3 years ago
21e29411af
Fix extractor bugs ( #2454 )
...
* Add debug/trace logging to extract_items
* Handle invalid timestamps for livestreams extraction
* Make use of author_fallback in playlist extractor
* Don't use extract_text for video length extraction
The extract_text function attempts to extract from both the simpleText and
the runs route. This is typically what we'd want for text extraction as
it could appear in both locations. However, while this still holds true,
the thumbnailOverlayTimeStatusRenderer writes a numerical length (when
present on the video) to the simpleText route and uses runs for a
text overlay like "LIVE" or "PREMIERE".
Therefore, when a video has a text overlay instead of a numerical one,
Invidious still passes it onto decode_length_seconds, which obviously
raises since it cannot be converted into integers.
In the future, if more routes requires one text route over the other, we
should go ahead and add an argument to extract_text itself. Though for
now, this is sufficient.
* Handle unsupported "special" categories
3 years ago
adc12addfa
Add config option to display source code URL in footer ( #2450 )
3 years ago
d806310665
Revert "Fix typo ( #2456 )" ( #2457 )
...
This reverts commit 4982bff74d
3 years ago
4982bff74d
Fix typo ( #2456 )
3 years ago
81b12b8001
Add support to make invidious API-only via flag ( #2363 )
3 years ago
3e781b7d13
Merge pull request #2443 from iv-org/syeopite-patch-1
...
Use make_client when querying instance api
3 years ago
9c44e41a4c
Merge pull request #2228 from syeopite/extract-items-overhaul
...
Overhaul extract_item(s) functions and add infrastructure for parsing YouTube categories
3 years ago
73eabb6ca2
Actually fix lint
3 years ago
5a52b4fe45
Fix lint
3 years ago
caa08a6379
Disable locales with less than 50% of strings translated
3 years ago
cd02078e26
Add Portuguese (pt) to locales
...
follow up to #2437
3 years ago
77131cff91
Use make_client when querying instance api
3 years ago
7b2aa5f98e
add icon-buttons to playlist items ( #2442 )
3 years ago
26b28cea49
Use break instead of short-circuit return
3 years ago
23049e026f
Improve readabltiy of SearchChannel auto-gen detect
3 years ago
9ab242ca2e
Optimize routing logic of extract_item(s) funcs
3 years ago
aa59925374
Rename get_browse_endpoint to get_browse_id
3 years ago
43ea8fa706
Convert nil for AuthorFallback to empty strings
3 years ago
6df85718e6
Apply suggestions from code review
...
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
3 years ago
9ba3e1cdb4
Decrease channel refresh frequency (1 min -> 1 h)
...
This is a temporary fix to reduce load on instances with many channels and avoid IP being flagged by Google.
3 years ago
b20f72b963
Use default timeout (5 seconds) for YT pool ( #2430 )
3 years ago
092b8a4e52
Add documentation to extractors.cr
3 years ago
e5f07dedbf
Typos and tiny styling changes
3 years ago
ca9eb0d539
Bountiful extractor changes
...
- Add extract_text to simplify extraction of InnerTube texts
- Add helper extractor methods to reduce repetition in parsing InnerTube
- Change [] more than 2 blocks long to use #dig or #dig?
- Remove useless ?.try blocks for items that always exists
- Add (some) documentation to VideoRendererParser
3 years ago
142317c2be
Overhaul extractors.cr to use modules
3 years ago
3dea670091
Switch to structs in extractors.cr for performance
3 years ago
8435e79913
Improve documentation for extract_item(s) funcs
3 years ago
30e85b40f9
Fix extract_videos
3 years ago
be1a43a337
Manually extract category refactor from 1b569bbc99
...
Also fixes some errors caused by cherry-picking
3 years ago
abca8f7a7c
Rename invidiousitems.cr
3 years ago
7b60dac526
Add description_html field to Category
...
(cherry picked from commit aa8f15f795
3 years ago
ea6434662d
Change typing of Category contents to only Array
...
(cherry picked from commit d3384e17f1
3 years ago
0b7a108a59
Move continuation_token out of Category struct
...
(cherry picked from commit 0e96eda28f
3 years ago
57c63f3598
Rename "items_without_cate_items" to reflect usage
3 years ago
ae30f32c36
Unpack search items that are embedded in categories
...
This is a squash of a bunch of commits
cherry-picked commits
Fix category parse error on search
(cherry picked from commit cc02fed4e62605b9c609ca4afd59f4cc10675610abda6840d5491e33450e
3 years ago
a50f64f6e9
Add parser for categories (shelfRenderer)
...
This commit adds a new parser for YT's shelfRenderers which are
typically used to denote different categories.The code for featured
channels parsing has also been moved to use the new parser but some
additional refactoring are needed there.
The ContinuationExtractor has also been improved and is now capable of
extraction continuation data that is packaged under
"appendContinuationItemsAction"
In additional this commit adds some useful helper functions to extract
the current selected tab the continuation token. This is to mainly
reduce code size and repetition.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.
(cherry picked from commit 8000d538db
3 years ago
1323b94b7a
Rewrite extract_item and extract_items functions
...
This commit completely rewrites the extract_item and extract_items
function. Before this commit these two function were an unreadable
mess. The extract_item function was a lengthy if-elsif chain
while the extract_items function contained an incomprehensible
mess of .try, else and ||.
With this commit both of these functions have been pulled into a
separate file with the internal logic being moved to a few classes.
This significantly reduces the size of these two methods, enhances
readability and makes adding new extraction/parse rules much simpler.
See diff for details.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.
(cherry picked from commit a027fbf7af
3 years ago
6d68fbc31d
Fix livestream regex regression caused by #2271
...
Closes #2352
Special thanks to @WaywardHeart for finding this issue!
3 years ago
86ca568d6d
Remove login type button from frontend ( #2423 )
3 years ago
2b0bb69a4f
Fix mixes route ( #2421 )
3 years ago
87f46a7532
Unregister captcha job ( #2390 )
3 years ago
4a0359c04e
Pass success msg from dep script during compile-time
3 years ago
02431b3f98
Use correct videojs-vtt-thumbnails location in licences.ecr
3 years ago
0323202a03
Revert to iv-org fork of silvermine-videojs-quality-selector
...
Upstream requires at least two additional sources. Whereas Invidious needs it to be
able to display a single additional source for normal (dashless)
qualites. Aka medium and hd720.
3 years ago
62c1991b88
Typo
3 years ago
3a6085ad31
Readd player.css
3 years ago
2451497b31
Typo
3 years ago
06a1d2ac41
Rename fetch_videojs* to fetch_player*
3 years ago
262131f68e
Add script to resolve and fetch VideoJS files
3 years ago
e655af251c
Try not to log search queries ( #2362 )
3 years ago
5054510d15
Prevent VR from being initialized in listen mode ( #2396 )
3 years ago
947fe4fbb3
HTML escape video mimetype
...
Video mimetype may contain code information between double quotes.
If not properly escaped, it breaks the browser's parser. E.g:
```
type="video/mp4; codecs=" avc1.64001f,="" mp4a.40.2""=""
```
Thank Robin for catching this!
3 years ago
50c8afb525
Handle equirectangular projections for VR ( #2379 )
3 years ago
a539de4f97
Bump dependencies ( #2378 )
...
* Upgrade to Kemal v1.1.0
* Bump postgres driver
3 years ago
8d5a867271
Merge pull request #2380 from syeopite/fix-invidious-showing-yt-redirect-links
...
Fix invidious showing yt redirect links
3 years ago
387bddb51b
Improve detection and handling of yt redirect links
3 years ago
41ba19b615
fix comment replies
3 years ago
a28945273d
Propagate replacing yout.be links to /watch to RSS
3 years ago
fd6f03655e
Fix typo causing links to be youtube.com/redirect
3 years ago
8b62c05fe2
remove 3gp only from the player ( #2376 )
...
+ video quality precedence on default player when js is not enabled
3 years ago
a1001ada47
Properly transform youtu.be links to be /watch routes in comments and descriptions ( #2365 )
3 years ago
8e3ff79f22
Remove the mention of 'Omar Roth' from the footer
3 years ago
4fcd0964cd
Extract API routes ( #2271 )
...
* Extract API routes from invidious.cr
* Remove deprecated APIs
- insights
- top feed
3 years ago
5005212bec
Extract feed routes ( #2269 )
...
* Extract feed routes from invidious.cr
* Removes the deprecated route for /feed/top
* Deprecate /view_all_playlist & use /feed/playlists
* Move feed views into their own directory
* Add haltf method to halt current route context
* Change status_code + return blocks to use haltf
* Set appropriate response headers for RSS routes
3 years ago
a279d6f433
Fix livestream parsing URLs ( #2356 )
3 years ago
fceb8093f1
Use `athena-negotiation` to detect language through Accept-Language header ( #2324 )
...
Detect language through Accept-Language header
3 years ago
d984a898d4
Remove usage of haltf in /api/v1/channels/:ucid/comments
3 years ago
52688106e4
Fix /api/v1/search/suggestions route link
3 years ago
66b45a8fe2
Bountiful changes
...
- Use haltf in more locations
- Fix wrong URL params
- Rename API modules
- Remove API routing file and move everything to general iv routing
file
3 years ago
b5d2eb5c70
fetch with innertube api when video is unavailable ( #2329 )
...
+ rename some client type to better names
+ fix thirdParty hack
3 years ago
25362f16a0
Readd paid attribute for videos ( #2330 )
3 years ago
39b34eece8
Extract API routes from invidious.cr (3/3)
...
- Auth (excluding notifications*) APIs
- Mixes
*Notifications currently require the "connection_channel" channel
for talking with the notifications job. Unfortunately, we cannot
access that within the route modules yet.
3 years ago
b3426fdc94
Restructure API routes to use more namespaces
3 years ago
6aa65593ef
Extract API routes from invidious.cr (2/?)
...
- Video playback endpoints
- Search feed api
- Video info api
3 years ago
66becbf46f
Restructure API route organisation
3 years ago
cbf3d75087
Extract API routes from invidious.cr (1/?)
3 years ago
0b0036813f
Remove deprecated APIs
...
- insights
- top feed
3 years ago
c06a20e085
Switch to innertube API for videos ( #2220 )
...
Commit history:
- Switch to innertube API for videos
- fix hardcoded strings + fix bypass geo-restriction
3 years ago
12b46bbd41
switch to innertube API for about channels ( #2255 )
3 years ago
cea38de4ad
Check for existance of "adaptiveFormats" in videos
...
Combined from commits:
- Check for existance of "adaptiveFormats" in videos
- Remove usage of ternary conditional
3 years ago
6745ca7775
fix comments using dig
3 years ago
88c5e3b6fa
Use the new youtube api for comments ( #2217 )
...
* use the new youtube api for comments
* remove PG_DB & action parameter + allow force region
* support new comments data with onResponseReceivedEndpoints
3 years ago
7afa027b95
Switch routing logic to use modules ( #2298 )
...
* Switch routing logic to use modules
* Add more macros for adding routes of different HTTP methods
3 years ago
9b74cf3225
Typo
3 years ago
1321c90920
Extract channel routes ( #2227 )
...
* Extract primary channel routes from invidious.cr
Also removes timedtext_video stub since all it does is redirect to the
homepage. However, Invidious's 404 handler already does this.
--
As the template for the channel about page doesn't exist yet, the
behavior for the /channel/:ucid/about endpoint has been changed to be
the same as what's currently present on Invidious
(cherry picked from commit 8fad19d8051b569bbc9953335fe7cf8fc6f3add6
3 years ago
4b46313e19
Fix crystal overrides ( #2295 )
...
* Move Crystal stdlib classes overrides to a separate file
* Document known crystal overrides
* Update crystal overrides for HTTP::Client socket
* Update shard.yml to restrict crystal versions
* Fix compilation error in Crystal 1.1.x (See
https://github.com/crystal-lang/crystal/issues/10965
for more details about this issue).
3 years ago
e9add69e26
Fix #resolve_url by adding ClientConfig argument
...
The private `_post_json` method of the YoutubeAPI requires a ClientConfig
as the third parameter. This was passed in all Youtube API methods except the
`#resolve_url` method.
3 years ago
5b020e81ca
Youtube api improvements ( #2277 )
...
* Put youtube API functions under the YoutubeAPI namespace
* Implement the following endpoints:
- `next`
- `player`
- `resolve_url`
* Allow a ClientConfig to be passed to YoutubeAPI endpoint handlers.
* Add constants for many new clients
* Fix documentation of YoutubeAPI.browse(): Comments and search
result aren't returned by the browse() endpoint but by the next()
and search() endpoints, respectively.
* Accept gzip compressed data, to help save on bandwidth
* Add debug/trace logging
* Other minor fixes
3 years ago
84594b0e1e
Remove workaround for decompression of proxied files ( #2286 )
...
Was used by `proxy_file` before crystal 0.35.0.
Implemented in: f7dbf2bdd4d30a972a90
3 years ago
578bbcd181
Fix raw parameter for videos in listen mode ( #2270 )
3 years ago
bc937a6434
Add Korean (ko.json) to loaded locales
...
Required because of c83113d49b
3 years ago
095c894548
Merge pull request #2201 from pinchese/patch-1
...
futureproof comment avatars
3 years ago
56ebef4352
Multiple front-end fixes ( #2247 )
...
Fixes:
* Sanitize user-provided content in HTML (Fixes #2193 )
* Fix encoding of search query in prev/next pages (Fixes #2229 )
* Fix some issues introduced with #2196 :
- Fix alignment of all <h3> elements (Move the inline style from the parent to the <h3> element)
- Add missing comma on 'dir' HTML attribute (Typo introduced by PR #2196 )
Code cleaning:
* Remove unnecessary 'each_sclice' + 'each' double loop in ECR files
* Clean the player's <source> list generation code (in player.ecr)
3 years ago
3e5c353298
Merge pull request #2205 from syeopite/fix-age-restricted-videos
...
Partial (and temporary) fix for age restricted videos
3 years ago
0d57a887ea
Mute unbuffered_flush IOError exception ( #2235 )
...
Related to #1416 , it doesn't really fix the real error, but instead mutes the exception message.
Like explained in #1416 , this "exception Error" while flushing the client data doesn't harm the client-server connection. However, this exception message continuously spams the logs and makes debugging and error finding really difficult.
3 years ago
ae61662f61
Debloat channels.cr into multiple files ( #2225 )
...
Cherry picked from ui overhaul branch with a few modifications:
- channel folder is renamed to channels
- parsing for channel home and featured channels are removed due to
lack of infrastructure from other commits
(cherry picked from commit 44d18b8e14
3 years ago
c0e8feb66e
Add new and missing locales to i18n.cr
...
New locales: lt, vi
Missing: bn_BD, cs, da, eu, hu-HU, si, sk, sr, sr_Cyrl
3 years ago
39110ad21c
Use struct for caption object
3 years ago
57bb8c610a
Use embed stream pull as fallback for gated videos
3 years ago
cf619f24a9
Remove workaround for kemalcr/kemal/issues/575 ( #2230 )
...
Full URL of the issue: https://github.com/kemalcr/kemal/issues/575
3 years ago
67a18dcff6
Merge pull request #2196 from ahangarha/patch-1
...
Add bi-directional text support
3 years ago
54b19a04bb
Fix caption parsing on age restricted videos
3 years ago
ca4df29670
Wrap comment
3 years ago
7da0b2fd7f
Switch from URI::Params.new to URI::Params.encode
3 years ago
cfcb64c516
Fix layout of video 'card' items
...
Previous changes broke alignment of text and icons
3 years ago
135ae11c20
Merge pull request #2195 from B0pol/trending
...
Use youtubei API for trending
3 years ago
ce68d09d26
Pick a random video for bypass captcha
...
pick a random video from the 1000 first rows of the channel_videos table
in order to bypass the captcha more efficiently
3 years ago
aa55e67389
Fix extraction of age restricted videos
3 years ago
f7992d2d09
futureproof comment avatars
...
i was injecting custom css into the site that made the avatars round, and noticed comment avatars looked a little odd
i opened dev tools and siffed through the html, and noticed that the image was being padded,
when it would look nicer if the element used margin instead of padding
with padding:
https://imgur.com/c0pB37e
with proposed changes (margin instead of padding):
https://imgur.com/iKmBzEi
3 years ago
eecfc155b8
Right-align the RSS icon in channel playlists
3 years ago
9cef7945c0
Fix RTL text in video titles on Firefox
...
The behavior was as follow: on Right-To-Left text (e.g Arabic) that is wrapped
(because it's too long to fit on one line), the second row and following rows
may or may not be right aligned (as RTL text should be). Opening the devtools
fixes that alignement, as consistently as closing the devtool breaks it.
This problem seems to arrive only in the following configurations (link nested
in a paragraph, both of which may or may not have the dir= attribute):
* `<p><a href="some_link">RTL_TEXT</a></p>`
* `<p><a href="some_link" dir="auto">RTL_TEXT</a></p>`
* `<p dir="auto"><a href="some_link">RTL_TEXT</a></p>`
with the following CSS:
```
p {
unicode-bidi: plaintext;
text-align: start;
}
```
Changing the HTML to the following configuration (a paragraph with the dir=
attribute, nested in a link) seems to fix it:
`<a href="some_link"><p dir="auto">RTL_TEXT</p></a>`
3 years ago
1b1932f787
fix feed alignment on community view
3 years ago
9e4fd193c6
Limit descriptions width to ease mixed LTR/RTL text reading
...
This will prevent, on large pages, the LTR and RTL text to be
far away, on each side of the page. This could happen on channel
and playlists descriptions, when the page is displayed on a large
screen.
3 years ago
d16a748f37
set alignment for feed link
3 years ago
7ec93825b6
Change description-box from flex to block
...
I also make minor changes to the surroundings so that the same layout
and functionality as before is preserved.
3 years ago
50267a6dd6
Use youtubei API for trending
3 years ago
5a8825d016
Fix quoting of 'none' in CSP header
...
The keyword 'none' must be surrounded by single quotes.
Regression introduced by #2168 .
3 years ago
4803285e50
update video URL for recaptcha detection
3 years ago
349f073b8e
Remove unnecessary "Welcome, " on username display
3 years ago
90c907710c
Display username in header
3 years ago
cb525af0a2
Connect to api.invidious.io with https
3 years ago
Samantaz Fox